[receiver/prometheusremotewrite] flaky test #37563
Conversation
perebaj
changed the title
| req := httptest.NewRequest(http.MethodPost, "/api/v1/write", bytes.NewBuffer(compressedBody)) | ||
| req.Header.Set("Content-Encoding", "snappy") | ||
| req.Header.Set("Content-Type", "") | ||
| w := httptest.NewRecorder() |
There was a problem hiding this comment.
@ArthurSens It's not done yet. It's just an idea. Did you see any problem to use httptest instead of call setupServer? Like you did here ⬇️
httptest take care of a bunch of things. Including the creation of a valid base url and ports. For that specific case where we are just validating the expected statusCode given a header, I think that would be a good approach to avoid the flaky test thing. WDYT?
There was a problem hiding this comment.
@pjanotti some constraint about this approach?
There was a problem hiding this comment.
Yes, I like your approach! Let's do it!
.chloggen/prw-flaky-test.yaml
Outdated
| @@ -0,0 +1,27 @@ | |||
| # Use this changelog template to create an entry for release notes. | |||
There was a problem hiding this comment.
I know I asked you to add this changelog entry, but I think the correct option is to add the skip changelog label since the change isn't related to the collector user
There was a problem hiding this comment.
Should I remove it, then?
|
/label "Skip Changelog" not sure if this will work, let's see |
I think that you need to set this label
|
I dont have permission 🙃 |
|
Yeah, I don't have it either; we need to wait for an approver/maintainer. All that's left to do here is remove the draft :) |
Description
Using httptest package instead of starting a real server avoiding port conflicts.
Link to tracking issue
Fixes #36654