-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/tcpcheck] Add New Receiver#34458 #37556
base: main
Are you sure you want to change the base?
[receiver/tcpcheck] Add New Receiver#34458 #37556
Conversation
@yanfeng1992 To add you as a code owner for running pipeline checks, could you create a new PR for membership? Thanks! Here’s an example: link |
c5b5ae7
to
1c40246
Compare
Hi @yanfeng1992, If you become an otel member, we’d be happy to add you back, or You can also create a new PR if needed. Let me know if you have any questions! Thanks for your understanding! |
f157be2
to
17d64d9
Compare
Hi @atoulme, I hope you're doing well! I would love your feedback whenever you have time. Let me know if I can improve anything to make this easier to review :) . Thanks! |
47dcae3
to
cfbe1df
Compare
@chengchuanpeng please make CI pass so I can review? I will take a look anyway now |
Run |
31316f0
to
4161073
Compare
@atoulme , I pushed the changs, and CI passed, please check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b83892a
to
8306cd1
Compare
[receiver/tcpcheck] Change CODEOWNERS#34458 [receiver/tcpcheck] Change CODEOWNERS#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Fix Version And Test#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Temporarily Change Owner#34458 [receiver/tcpcheck] Change Version#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Rebase#34458 [receiver/tcpcheck] Fix Test#34458 [receiver/tcpcheck] Make Tidy#34458
[receiver/tcpcheck] Change CODEOWNERS#34458 [receiver/tcpcheck] Change CODEOWNERS#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Fix Version And Test#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Temporarily Change Owner#34458 [receiver/tcpcheck] Change Version#34458 [receiver/tcpcheck] Rebase#34458
8306cd1
to
0d17535
Compare
Signed-off-by: huangyanfeng [email protected], chengchuanpeng [email protected],
This PR builds upon the work from @yanfeng1992. We really appreciate the effort and thought he put into the original implementation, which laid the groundwork for this update. While there were some changes needed, his contribution was instrumental in guiding the direction of this PR
Description:
To monitor the availability and performance of TCP endpoints.
Use case: TCP network detection plug-in, usually used to monitor whether a TCP port on the local machine is listening, or whether a remote port can be connected
Link to tracking Issue:
#34414
Testing:
(1) PR Includes coverage ~85% in the package with the scraper.
(2) Also includes coverage ~80% in the internal/configtcp package
Documentation:
The new receiver includes documentation in receiver/tcpcheckreceiver/README.md and receiver/tcpcheckreceiver/documentation.md.