Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/tcpcheck] Add New Receiver#34458 #37556

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chengchuanpeng
Copy link

@chengchuanpeng chengchuanpeng commented Jan 28, 2025

Signed-off-by: huangyanfeng [email protected], chengchuanpeng [email protected],

This PR builds upon the work from @yanfeng1992. We really appreciate the effort and thought he put into the original implementation, which laid the groundwork for this update. While there were some changes needed, his contribution was instrumental in guiding the direction of this PR

Description:

To monitor the availability and performance of TCP endpoints.
Use case: TCP network detection plug-in, usually used to monitor whether a TCP port on the local machine is listening, or whether a remote port can be connected

Link to tracking Issue:

#34414

Testing:
(1) PR Includes coverage ~85% in the package with the scraper.
(2) Also includes coverage ~80% in the internal/configtcp package

Documentation:

The new receiver includes documentation in receiver/tcpcheckreceiver/README.md and receiver/tcpcheckreceiver/documentation.md.

Copy link

linux-foundation-easycla bot commented Jan 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@chengchuanpeng
Copy link
Author

chengchuanpeng commented Feb 4, 2025

@yanfeng1992 To add you as a code owner for running pipeline checks, could you create a new PR for membership? Thanks! Here’s an example: link

@chengchuanpeng
Copy link
Author

Hi @yanfeng1992,
Since we need to use tccheckreceiver, and the pipeline will fail if you're not a member of otel, I have to remove you from the CODEOWNERS file. I’m really sorry about that.

If you become an otel member, we’d be happy to add you back, or You can also create a new PR if needed. Let me know if you have any questions!

Thanks for your understanding!

@chengchuanpeng
Copy link
Author

Hi @atoulme, I hope you're doing well! I would love your feedback whenever you have time.

Let me know if I can improve anything to make this easier to review :) . Thanks!

@chengchuanpeng chengchuanpeng force-pushed the tcpcheck-receiver branch 2 times, most recently from 47dcae3 to cfbe1df Compare February 24, 2025 17:52
@atoulme
Copy link
Contributor

atoulme commented Feb 24, 2025

@chengchuanpeng please make CI pass so I can review? I will take a look anyway now

@atoulme
Copy link
Contributor

atoulme commented Feb 24, 2025

Run ./.github/workflows/scripts/check-collector-module-version.sh and push the changes.

@chengchuanpeng chengchuanpeng force-pushed the tcpcheck-receiver branch 2 times, most recently from 31316f0 to 4161073 Compare February 24, 2025 22:18
@chengchuanpeng
Copy link
Author

chengchuanpeng commented Feb 24, 2025

@chengchuanpeng please make CI pass so I can review? I will take a look anyway now

@atoulme , I pushed the changs, and CI passed, please check!
Appreciate your help!

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengchuanpeng chengchuanpeng force-pushed the tcpcheck-receiver branch 2 times, most recently from b83892a to 8306cd1 Compare February 25, 2025 18:06
[receiver/tcpcheck] Change CODEOWNERS#34458

[receiver/tcpcheck] Change CODEOWNERS#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Fix Version And Test#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Temporarily Change Owner#34458

[receiver/tcpcheck] Change Version#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Rebase#34458

[receiver/tcpcheck] Fix Test#34458

[receiver/tcpcheck] Make Tidy#34458
[receiver/tcpcheck] Change CODEOWNERS#34458

[receiver/tcpcheck] Change CODEOWNERS#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Fix Version And Test#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Temporarily Change Owner#34458

[receiver/tcpcheck] Change Version#34458

[receiver/tcpcheck] Rebase#34458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants