[chore]: enable early-return from revive #37119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Aneurysm9,
crobert-1,
dmitryax and
mxiamxia
mmorel-35
changed the title
mmorel-35
force-pushed
the
revive/early-return
branch
from
4e5e126 to
e0f1a49
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
e0f1a49 to
30d22ab
Compare
github-actions
bot
added
exporter/prometheus
receiver/prometheus
mmorel-35
force-pushed
the
revive/early-return
branch
from
30d22ab to
5b8a767
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
5b8a767 to
88afdef
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
88afdef to
4e4838d
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
4e4838d to
da95aa7
Compare
mmorel-35
requested review from
TylerHelmuth,
ChrsMark,
mx-psi and
songy23
as code owners
mmorel-35
force-pushed
the
revive/early-return
branch
from
69daecf to
36350ff
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
36350ff to
77fdc66
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
77fdc66 to
e723f45
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mmorel-35
force-pushed
the
revive/early-return
branch
from
e723f45 to
d2b392b
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
d2b392b to
f66bd61
Compare
atoulme
approved these changes
Feb 14, 2025
|
Just need to fix a conflict, looks ok otherwise. |
mmorel-35
force-pushed
the
revive/early-return
branch
from
f66bd61 to
8c56e4a
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
from
8c56e4a to
0c5560a
Compare
mmorel-35
force-pushed
the
revive/early-return
branch
2 times, most recently
from
4dce962 to
a47bf7e
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
revive/early-return
branch
from
a47bf7e to
7863ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
early-return: In Go it is idiomatic to minimize nesting statements, a typical example is to avoid if-then-else constructions.