-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fixing - feedback - Default view for Stars and Forks graph should be time-series #3991
Conversation
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc @isabensusan - any thoughts on the design here? |
Hey everyone, Should I proceed with the proposed idea? |
@SURAJ-SHARMA27 I believe the original issue to be resolved was just changing the default. We can revisit changing the style of the chart separately. |
@SURAJ-SHARMA27 thanks for your contribution! But like @brandonroberts mentioned, if you take a close look at the original issue #3862 the goal was to just change the default view for the stars and forks charts from Daily to History. We are not currently looking to update the design of these charts, so I'll be closing this PR, but if you want to tackle changing the default view in a different PR you are welcome to do so! |
Okay, I understand. Should I just convert the stars and forks graph into a time-series graph as mentioned in the original issue? |
I'm not sure where we landed on this @open-sauced/design @open-sauced/engineering. |
I'm going to go ahead and close this for now. Feel free to reopen it if you want to continue working on this @SURAJ-SHARMA27. |
Description
Fixes #3862
I have replaced the previous bar charts with area charts in the star graphs. I have submitted this as a draft PR. If it works well, I will implement this change throughout.
Related Tickets & Documents
Fixes #3862
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?