chore: upgraded to Next.js 14 #2020
Conversation
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
package.json
Outdated
| "@storybook/nextjs": "^7.2.0", | ||
| "@storybook/react": "^7.2.0", | ||
| "@storybook/nextjs": "^7.5.2", | ||
| "@storybook/react": "^7.5.2", |
There was a problem hiding this comment.
This was required as Storybook builds were failing.
|
Only checking from phone, but get an internal service error when visiting the following link. https://deploy-preview-2020--oss-insights.netlify.app/hub/lists/new |
|
Also getting an error viewing a list |
|
This behaviour is seen on all pages that uses |
Don't spend too much time on that as this isn't a high priority atm. Not sure why I didn't see that. 🤔 |
|
Going to close this for now and revisit this later. |
nickytonline
force-pushed
the
nickytonline/upgrade-next-14
branch
from
dc5da4f to
6d94db3
Compare
|
|
I have to dig a bit, but with v5 RC 4, the deploy went well @MarcL and the site for the most part appears to be working, but our middleware does not appear to be working/kicking in. It looks like it may not have been deployed. As mentioned we're on the pages router and the middleware.ts file is in the root of the application. Full deploy logs here, https://app.netlify.com/sites/oss-insights/deploys/65f1f66440a3070008aeb3b3 We have a netlify.toml file but note the build command is in the UI, mainly because we're not set up as a monorepo atm and we deploy Storybook for another site, and the Storybook deploy command is handled in the Netlify UI as well. I don't think this would affect the build, but just mentioning it. As mentioned, I'll dig deeper tomorrow. |
|
@nickytonline - I've brought it up with the team and we'll have a look too. |
|
Hey @nickytonline! I've just tried this on a fork and it works fine as far as I can see. I added a log inside the middleware and I can see it being called. WHat are your build settings in the UI? |
|
In my deploy preview, our workspaces feature does not load the workspace but rather a non-existent page.
There's some legacy cleanup with the file based routing which is why a lot of non-existent routes load a page like the above. This is what should be loading (from our beta site as an example)
My reflex was the middleware wasn't working, but it is because it does redirect to a worspaces route, so that was just me not drinking enough coffee. 🤣 I thought it was working on your fork @ascorbic, but after login, you're redirected to our beta site because your domain isn't configured for Supabase. Here's the settings from the Netlify UI.
You can see this working if you run it locally. So I think the actual issue is why do Maybe the other file based route (legacy issue mentioned above) is taking precedence for some reason (not an issue with the current runtime) because the workspaces routes are generated. I haven't run Like I mentioned I haven't dug too deep yet. I have some other work to do this morning my time, but will dig a bit more this afternoon. |
|
I came back to the site after it just redeployed and now I can hit a workspaces page, so I think this might be some app code that caused my issue. This loads fine now, https://deploy-preview-2020--oss-insights.netlify.app/workspaces/3432aaf7-55db-4c2b-9fde-f61604471e21 .
I think this might be an issue in our code. 😅 cc: @brandonroberts I think there might be some client-side redirect wonkiness after logging in from the root as I got the generic greedy route initially (see above). I think for the time being we're all good. I'll continue to test things out @ascorbic @MarcL. |
|
@brandonroberts, it looks like our TLDR; it's probably me. 😅 |
|
That's great! Let us know how you get on |
|
The proof of concept with this demonstrated that everything is working with the release candidate of the Netlify Next Runtime. I will update this PR once the official version is released and updated automatically for our sites on Netlify @brandonroberts. |
nickytonline
force-pushed
the
nickytonline/upgrade-next-14
branch
2 times, most recently
from
f50f06c to
1f789e2
Compare
|
We're upgrading now. I believe I need to upgrade Storybook as well. Just taking a peek at that. |
|
Just looking into a Node.js out of memory error during the build, https://app.netlify.com/sites/oss-insights/deploys/663d28f3125be03906a1225f#L2272-L2290. |
|
Looks like I'm getting Node.js out of memory consistently during a build. https://app.netlify.com/sites/oss-insights/deploys/663d2b98d286670008400d65#L2275-L2293 |
|
A local build via |
|
I'm currently investigating file sizes in the Same for the |
|
So it looks like 14.1.1 works fine, but 14.2.x versions cause out of memory error issues @MarcL @ascorbic. Again, locally via I could allocate more memory to Node.js, but that seems kind of hacky since it only starts happening in 14.2.x. |
Looks like I could go as high as 14.1.4 for now. |
nickytonline
force-pushed
the
nickytonline/upgrade-next-14
branch
from
7a652da to
00d67bf
Compare
|
@nickytonline - We'll have a look at the runtime to see what's up. |
The OOM I looked at ( https://app.netlify.com/sites/oss-insights/deploys/663d2b98d286670008400d65#L2275-L2293 ) seems to happen during This is totally random but seeing some Sentry logs before OOM maybe this could be related getsentry/sentry-javascript#10468 ? Worth a try using their PS. Hi Nick! :) |
|
Hi @pieh! Thanks for digging in a bit! Yeah it does sound like it could be the Sentry issue you linked. I wasn't aware of that issue but we've also been on 13.x until now. 😅 |
nickytonline
requested review from
bdougie,
zeucapua and
jpmcb
and removed request for
a team
Yeah agreed. We don't need to be on the latest 14.x version anyway. I will keep tabs on the 14.2.x issue though. |
It looks like 14.2.4 is fine for deploys now. I ran a deploy preview and the build didn't run out of memory like it was previously. To update, run We should be good but check it what happens in opennextjs/opennextjs-netlify#2471 affects us since we're on the pages router and use middleware. |
Description
The deploy preview appears to be all good. I've navigated around the app a bit and things seem to be behaving correctly. Also trying out
next dev --turbofor faster local development.Take the deploy preview for a spin. If folks are happy with the smoke test, we can merge and monitor it in the beta environment for a bit before going to prod.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #2021
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?