Enable Build On Windows

[AdijeShen]

Solve Issue #1

Changes Made

• Changed from dynamic linking (liboqs.so/liboqs.dll) to static linking (liboqs.a)
• Added liboqs as a git submodule in ./liboqs/
• Updated build instructions for all platforms

Key Benefits

1. Simplified installation - no need to install liboqs in system directory
2. More portable - all dependencies contained within project
3. Consistent builds across platforms

Documentation Updates

• Preserved all existing API documentation
• Maintained all examples and usage instructions
• Kept original diagrams and status badges
• Updated only the build/installation sections

[baentsch]

AFAIK, we don't "like" submodules -- or would you be OK with this here, @dstebila @SWilson4 @vsoftco ?

[AdijeShen]

I'm fine with removing the submodules. This will require some documentation updates to reflect the changes. Let me know if you'd prefer this approach.

[SWilson4]

I'd rather not have the submodule if we can help it. The language wrapper should "just work" with new versions of liboqs as long as the core APIs don't change.

[dstebila]

Agreed; our approach so far has been to not include liboqs as a submodule.

[baentsch]

Thanks for this PR, @AdijeShen -- before going into review detail, I've asked the rest of the team as to whether they're OK with the submodule approach. The change I'd immediate question is the removal of RELEASE.md: If there's no good reason for this (?) please bring it back: As and if someone else starts to maintain this sub project again, there may be an interest to do new releases again...

[AdijeShen]

Sorry, just delete it accidentally, I would add it back

…

---Original--- From: "Michael ***@***.***> Date: Fri, Nov 1, 2024 18:29 PM To: ***@***.***>; Cc: "Huajie ***@***.******@***.***>; Subject: Re: [open-quantum-safe/liboqs-java] Enable Build On Windows (PR #28) @baentsch requested changes on this pull request. Thanks for this PR, @AdijeShen -- before going into review detail, I've asked the rest of the team as to whether they're OK with the submodule approach. The change I'd immediate question is the removal of RELEASE.md: If there's no good reason for this (?) please bring it back: As and if someone else starts to maintain this sub project again, there may be an interest to do new releases again... — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>