Add unic-segment component #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out using these properties is easier as a total property, instead of partial, as we implemented initially. The reason for it is the fact that the default value (called `Other` in this context) is usually used in the same level as other values. Update variant name for `WordBreak::DoubleQuote`, which was using the abbr name instead. Add missing component version test against `unic-ucd-core`.
behnam
added
A: lib-impl
The algorithm implementation is based on [`unicode-segmentation`](https://github.com/unicode-rs/unicode-segmentation). The API is kept minimal at the moment, with only segment boundry objects and their indices objects. As we expand our string-level APIs, we can add on what's needed.
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2017
174: Add unic-segment component r=behnam a=behnam Make all `unic-ucd-segment` properties Total, as turns out using these properties is easier as a total property, instead of partial, as we implemented initially. The reason for it is the fact that the default value (called `Other` in this context) is usually used in the same level as other values. The algorithm implementation is based on [`unicode-segmentation`](https://github.com/unicode-rs/unicode-segmentation), with changes to use `unic-ucd-segment`. The API is kept minimal at the moment, with only segment boundry objects and their indices objects. As we expand our string-level APIs, we can add on what's needed. The tests for the algorithm are imported. Also new test is created for `unic-ucd-segment`, using the same source. Closes <#135>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all
unic-ucd-segmentproperties Total, as turns out using these properties is easier as a total property, instead of partial, as we implemented initially. The reason for it is the fact that the default value (calledOtherin this context) is usually used in the same level as other values.The algorithm implementation is based on
unicode-segmentation, with changes to useunic-ucd-segment.The API is kept minimal at the moment, with only segment boundry objects and their indices objects. As we expand our string-level APIs, we can add on what's needed.
The tests for the algorithm are imported. Also new test is created for
unic-ucd-segment, using the same source.Closes #135