增加长按倍速的倍数设置功能 #1487
增加长按倍速的倍数设置功能 #1487
Conversation
| /** | ||
| * 长按倍速的倍数 | ||
| */ | ||
| val fastSkipTimes: Float = 3f, |
There was a problem hiding this comment.
参数名不好，建议改为 fastSkipMultiplier
| @@ -17,7 +17,7 @@ import me.him188.ani.app.ui.foundation.ProvideCompositionLocalsForPreview | |||
| @Composable | |||
| @Preview(widthDp = 1080 / 3, heightDp = 2400 / 3, showBackground = true) | |||
| @Preview(device = Devices.TABLET, showBackground = true) | |||
| internal fun PreviewEpisodePage() { | |||
| internal fun PreviewEpisodePage(fastSkipTimes: Float = 3f,) { | |||
There was a problem hiding this comment.
带有 @Preview 的预览函数不能有参数，看一下其他参数怎么传递的
There was a problem hiding this comment.
preview 直接写死 3f 就好了, 在下面 31 行写死 = 3f.
| @@ -270,6 +272,12 @@ internal fun EpisodeVideoImpl( | |||
| onExitFullscreen = onExitFullscreen, | |||
| family = gestureFamily, | |||
| indicatorState, | |||
| fastSkipState = rememberPlayerFastSkipState( | |||
There was a problem hiding this comment.
这种情况下最好直接在 EpisodeViewModel 里构建 FaskSkipState，传递 FastSkipState 给 UI。
There was a problem hiding this comment.
我觉得目前没必要, 两种写法 equally ok
目前你改成 VM 存 state 反而会更麻烦 (因为调用链太长了). 得等重构完播放页的 UI 才比较好改成你说的.
| ) | ||
| }, | ||
| onValueChangeCompleted = { | ||
| fun stringToFloat(str: String): Float? { |
| }, | ||
| isErrorProvider = { | ||
| try { | ||
| it.toFloat() |
| @@ -527,6 +528,38 @@ fun SettingsScope.PlayerGroup( | |||
| }, | |||
| title = { Text("播放失败时自动切换资源") }, | |||
| ) | |||
| HorizontalDividerItem() | |||
| TextFieldItem( | |||
There was a problem hiding this comment.
建议使用 DropdownMenuItem 让用户从给定的几个值里选择，不超过 4 个预设可选值
There was a problem hiding this comment.
1x 2x 2.5x 3x 就可以了. 目前用户想要的都是 2x 或者 3x.
| fun rememberPlayerFastSkipState( | ||
| playerState: PlaybackSpeed, | ||
| gestureIndicatorState: GestureIndicatorState, | ||
| fastSkipTimes: Float, | ||
| ): FastSkipState { | ||
| return remember(playerState) { | ||
| PlayerFastSkipState(playerState, gestureIndicatorState).fastSkipState | ||
| PlayerFastSkipState(playerState, gestureIndicatorState, fastSkipTimes).fastSkipState | ||
| } | ||
| } |
There was a problem hiding this comment.
fastSkipTimes 是一个值, 而且没有在 rememebr key 里, 会导致用户修改设置后, 新的设置不会反映到 UI. 建议把 fastSkipTimes 改成 provider:
fun rememberPlayerFastSkipState(
playerState: PlaybackSpeed,
gestureIndicatorState: GestureIndicatorState,
multiplierProvider: () -> Float,
): FastSkipState {
return remember(playerState, multiplierProvider) {
PlayerFastSkipState(playerState, gestureIndicatorState, multiplierProvider).fastSkipState
}
}(现有代码 gestureIndicatorState 也是没 remember 的, 这是一个 bug, 不过这个 PR 里不需要修复).
PlayerFastSkipState 里面每次使用都从 multiplierProvider 调用一下获取.
| @@ -267,7 +267,7 @@ private fun AniAppContentImpl( | |||
| context, | |||
| ) | |||
| } | |||
| EpisodeScene(vm, Modifier.fillMaxSize(), windowInsets) | |||
| EpisodeScene(vm, Modifier.fillMaxSize(), windowInsets, fastSkipTimes = vm.videoScaffoldConfig.fastSkipTimes) | |||
There was a problem hiding this comment.
不要在这里增加这个参数，因为这个参数是包含在 vm 里的，已经传递了
|
因为有段时间没有更新了, 我先改成 draft 了, 解决问题后欢迎重新标记为 ready |
在播放器设置最下面设置了长按倍速的倍数设置功能。
用了很笨的方法，一步一步传参。