Feature/propagate exceptions #3974
Merged
+444
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ure/propagate-exceptions # Conflicts: # backend/onyx/background/celery/tasks/indexing/tasks.py
added 2 commits
February 13, 2025 14:08
…ure/propagate-exceptions
…ure/propagate-exceptions
pablonyx
reviewed
Feb 14, 2025
added 2 commits
February 14, 2025 14:08
…ure/propagate-exceptions
pablonyx
reviewed
Feb 15, 2025
pablonyx
approved these changes
Feb 15, 2025
…ure/propagate-exceptions
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2025
* better propagation of exceptions up the stack * remove debug testing * refactor the watchdog more to emit data consistently at the end of the function * enumerate a lot more terminal statuses * handle more codes * improve logging * handle "-9" * single line exception logging * typo/grammar --------- Co-authored-by: Richard Kuo (Danswer) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DAN-1442.
https://linear.app/danswer/issue/DAN-1442/restoreimprove-exception-propagation-from-spawned-indexing-tasks
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.