Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-1379] Add a few missing properties and make toJson working with unknown fields in java #125

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

dvacca-onfido
Copy link
Contributor

@dvacca-onfido dvacca-onfido commented Oct 9, 2024

Add a few missing fields:

  • tasks list:
    • workflow_run_id
    • task_def_version
  • checks:
    • paused
    • version
    • privacy_notices_read_consent_given

Taking the opportunity for overriding the serialisation to Json to make it resilient to API changes adding new fields: as a short term remediation a new template has been added to override default one, but that change should be likely pushed to the openapi generator upstream repository.

NB: upstream template version is here, the one-line change has been denoted with mustache comment {{! }}.

@dvacca-onfido dvacca-onfido self-assigned this Oct 9, 2024
@dvacca-onfido dvacca-onfido changed the title Add missing fields [CAT-1379] Make toJson accepting unknown fields in java and add missing properties Oct 15, 2024
@dvacca-onfido dvacca-onfido marked this pull request as ready for review October 15, 2024 13:27
@dvacca-onfido dvacca-onfido changed the title [CAT-1379] Make toJson accepting unknown fields in java and add missing properties [CAT-1379] Add a few missing properties and make toJson working with unknown fields in java Oct 16, 2024
@dvacca-onfido dvacca-onfido merged commit f3a6e38 into master Oct 16, 2024
4 checks passed
@dvacca-onfido dvacca-onfido deleted the add-missing-fields branch October 16, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants