Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin vulnerable urllib3 version #124

Closed
wants to merge 1 commit into from
Closed

Unpin vulnerable urllib3 version #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generators/python/urllib3/templates/setup.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ PYTHON_REQUIRES = ">=3.7"
{{#apis}}
{{#-last}}
REQUIRES = [
"urllib3 >= 1.25.3, < 2.1.0",
"urllib3 >= 1.25.3",
Copy link
Contributor

@dvacca-onfido dvacca-onfido Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanPollock thanks for your contribution.

LGTM, let just add a comment to not forget about this change in case template got refreshed:

Suggested change
"urllib3 >= 1.25.3",
"urllib3 >= 1.25.3", {{! upper bound not needed, < 2.1.0 removed }}

"python-dateutil",
{{#asyncio}}
"aiohttp >= 3.0.0",
Expand Down