added support for authenticating updates from github #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,7 +161,9 @@ def update_pull_data(self, pull, data): | |||
| def accept_github_update(): | |||
| """ View for github web hooks to handle updates | |||
| """ | |||
| # TODO: verify request is from github | |||
| update_secret = app.config.get('GITHUB_UPDATE_SECRET') | |||
| if update_secret and request.args.get('secret') != update_secret: | |||
There was a problem hiding this comment.
if we want to be paranoid we could use werkzeug.security.safe_str_cmp: ("This function compares strings in somewhat constant time.")
|
👍 |
|
can we have a test for this? |
Conflicts: cinch/github.py
On branch update-secret Your branch is up-to-date with 'origin/update-secret'. Changes to be committed: (use "git reset HEAD <file>..." to unstage) modified: tests/conftest.py new file: tests/test_github.py
Conflicts: cinch/github.py tests/conftest.py tests/test_github.py
|
does this make use of https://developer.github.com/webhooks/securing/? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.