Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Naming service #571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thanhngoc541
Copy link

@thanhngoc541 thanhngoc541 commented Sep 10, 2024

What type of PR is this?

Feature

What this PR does:

Adds a naming service for wallets. Users can now register a domain name, which acts as a shortcut for their wallet address, at https://gno-naming-service.vercel.app/. The registered domain name will be displayed in the wallet and can be used in place of the wallet address.

This feature is currently available on the test4 network and will be rolled out to other networks soon.

@thanhngoc541 thanhngoc541 changed the title Naming service feat: Naming service Sep 10, 2024
@jinoosss
Copy link
Member

Thank you for creating a PR 🙏

However, before i can review this PR, i need to discuss whether we should support this feature.

Adena aims for formal, standardised feature support for Gno.

I don't think you should create dependencies on services that are managed by a specific team or individual.

This PR seems to be for feature support for gno.land/r/varmeta/demo/v1/domain/resolver,
should we support this specific feature?

@jinoosss
Copy link
Member

cc @dongwon8247

@dongwon8247
Copy link
Member

Gno already has username. Why do we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants