Skip to content

Commit

Permalink
PHP 8.4: disable E_DEPRECATED reporting
Browse files Browse the repository at this point in the history
8.4 adds deprecation notices on all methods that use a null default but
don't have a question mark in their typehint, which was/is a very common
pattern. Here we also have the problem that the question mark for
typehints requires PHP 7.1 or greater and the current Omeka Classic
support range goes back further than that.

We'll eventually increase the minimum and make these changes, but will
probably maintain the E_DEPRECATED block at least for a while, as
there's many plugins out in the world with this problem and a low
likelihood of getting fixes.

(see omeka/omeka-s#2233)
  • Loading branch information
zerocrates committed Feb 18, 2025
1 parent 79fb8a1 commit 90bddc0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions application/tests/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
require_once dirname(dirname(dirname(__FILE__))) . '/bootstrap.php';
require_once 'globals.php';

error_reporting(E_ALL);

ini_set('display_errors', '1');

define('TEST_DIR', dirname(__FILE__));
Expand Down
2 changes: 2 additions & 0 deletions bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* @package Omeka
*/

error_reporting(E_ALL & ~E_DEPRECATED);

// Define the current version of Omeka.
define('OMEKA_VERSION', '3.2-dev4');

Expand Down

0 comments on commit 90bddc0

Please sign in to comment.