Converting Target kind and crate_types to enum representation

[michaelciraci]

Converting Target kind and crate_types to enum representation, along with an Unknown(String) as a fallback.

This is in response to the following issue: #239

[oli-obk]

Thanks for working on this.

Please update the changelog, too

[michaelciraci]

I was looking into why it failed for nightly, and it looks like the main branch is also failing nightly. I have the fix. Do you want me to add it here to get this nightly pipeline working again, or open a new merge request?

[oli-obk]

Either is fine with me. Whatever works for you

[michaelciraci]

It looks like the latest version of cargo-platform (v0.1.6), has a msrv of 1.70. However v0.1.5 works with 1.56. I put an upper limit on cargo-platform to keep the msrv of 1.56.

[jplatte]

I put an upper limit on cargo-platform to keep the msrv of 1.56.

That is generally a very bad idea, as it leads to un-resolvable dependency trees when another dependency in the tree requires cargo-platform = "0.1.6". Instead, I would recommend updating the MSRV CI job to run cargo update -p cargo-platform --precise 0.1.5 before checking compilation. There are also other solutions that don't require touching the CI job (or Cargo.toml) whenever a dependency bumps its MSRV in a patch release, but they're more involved; maybe the maintainers have a preference towards one such solution, I'm just a contributor.

[michaelciraci]

Yeah, there are multiple ways to deal with this and I'll defer to the maintainers on this.

The pull request was really for something else, so I can revert the cargo-platform change and that can be dealt with in a different pull request as well.

[oli-obk]

The pull request was really for something else, so I can revert the cargo-platform change and that can be dealt with in a different pull request as well.

yes please remove that commit

[oli-obk]

Please remove the commits, instead of using a new commit to revert the previous one

[michaelciraci]

Should be good now :)

[oli-obk]

Thanks!