Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-ffmpeg: Add AMD AV1 B-frame support #11521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

obs-ffmpeg: Add AMD AV1 B-frame support #11521

wants to merge 1 commit into from
+25 −2

Conversation

rhutsAMD
Copy link
Contributor

@rhutsAMD rhutsAMD commented Nov 13, 2024 •
edited
Loading

Description

Motivation and Context

  • Enable support for upcoming AV1 B-frame feature

How Has This Been Tested?

  • Tested on local AMD systems with and without AV1 B-frame support

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Lain-B
Lain-B approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@Lain-B Lain-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, rebase after feature freeze and after the deps update is merged.

@WizardCM WizardCM added the New Feature New feature or plugin label Nov 16, 2024
@RytoEX RytoEX self-assigned this Nov 19, 2024
@rhutsAMD rhutsAMD mentioned this pull request Dec 12, 2024
Merged
6 tasks
@rhutsAMD rhutsAMD force-pushed the amf-av1-bframe-support branch from cfaa52f to db1de4b Compare December 12, 2024 20:23
@rhutsAMD
Copy link
Contributor Author

Rebased to pull in latest changes from base branch

@rhutsAMD rhutsAMD force-pushed the amf-av1-bframe-support branch from db1de4b to 90fa0c4 Compare February 26, 2025 21:54
@rhutsAMD
Copy link
Contributor Author

Rebased to pull in the AMF dependency upgrade

@RytoEX
Copy link
Member

RytoEX commented Feb 26, 2025

Rebased to pull in the AMF dependency upgrade

The dependency update was only just merged on the obs-deps repo. There is no obs-deps release containing the update itself.

@RytoEX
Copy link
Member

RytoEX commented Mar 11, 2025

Please rebase this now that the updated dependencies have landed.

@rhutsAMD rhutsAMD force-pushed the amf-av1-bframe-support branch from 90fa0c4 to 4839913 Compare March 11, 2025 20:37
RytoEX
RytoEX requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.

@rhutsAMD rhutsAMD force-pushed the amf-av1-bframe-support branch from 4839913 to 24fe571 Compare March 12, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

@Lain-B Lain-B Lain-B approved these changes

Assignees

@RytoEX RytoEX

Labels
New Feature New feature or plugin
Projects
OBS Studio 31.1 PR Considerations
Status: Blocked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhutsAMD @RytoEX @Lain-B @WizardCM