Print basic browser source rendering crashes to OBS log #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While we cannot route most CEF/Chromium logging, we can catch rendering crashes and log them ourselves.
Docs: https://cef-builds.spotifycdn.com/docs/127.0/classCefRequestHandler.html#a6998e9b6ee7b0e9a810567fad3a6b4ea
Wording improvements welcome.
Example using
chrome://crash/
:Wasn't sure whether I should implement the same for browser docks. If others believe it's worth doing, I can make that change too.
Motivation and Context
While looking into ways to log iframe crashes, I came across this function which provides insight into browser renderer crashes. While this function doesn't seem to run for the specific crash a user experienced, I felt it was a useful case to handle.
How Has This Been Tested?
chrome://crash/
Types of changes
Checklist: