Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print basic browser source rendering crashes to OBS log #475

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

WizardCM
Copy link
Member

@WizardCM WizardCM commented Feb 12, 2025

Description

While we cannot route most CEF/Chromium logging, we can catch rendering crashes and log them ourselves.

Docs: https://cef-builds.spotifycdn.com/docs/127.0/classCefRequestHandler.html#a6998e9b6ee7b0e9a810567fad3a6b4ea

Wording improvements welcome.

Example using chrome://crash/:

22:19:49.388: [obs-browser: 'Crash page'] Webpage has crashed unexpectedly! Reason: 'STATUS_ACCESS_VIOLATION'

Wasn't sure whether I should implement the same for browser docks. If others believe it's worth doing, I can make that change too.

Motivation and Context

While looking into ways to log iframe crashes, I came across this function which provides insight into browser renderer crashes. While this function doesn't seem to run for the specific crash a user experienced, I felt it was a useful case to handle.

How Has This Been Tested?

  • Add a browser source
  • Set it to chrome://crash/
  • See the entry in the log

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement New feature or improvement label Feb 12, 2025
@WizardCM WizardCM force-pushed the source-crash-logging branch from a890d0c to d61c01f Compare February 12, 2025 11:46
@RytoEX RytoEX self-assigned this Feb 12, 2025
@RytoEX RytoEX merged commit 52c1527 into obsproject:master Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants