-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardware accel support under Linux #453
base: master
Are you sure you want to change the base?
Conversation
3ee8f81
to
5496ec4
Compare
5496ec4
to
e3b65ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine overall, i really wish we could pin down the modifier issue on x11 to something in cef's codebase... at least then we could see if it ever got fixed in the future.
Doesnt compile with |
Maybe i'm missing something on how this was tested, but current master sets the BrowserHwaccel option to false so nothing here takes effect until https://github.com/obsproject/obs-studio/blob/master/UI/obs-app.cpp#L1268-L1278 is flipped. |
https://gist.github.com/kkartaltepe/ebf66527a38f188c8b07eb43b2d37de6 I dont remember if this happened as well on my original test months ago. But on my steamdeck tier setup there is significant rendering performance loss so rendering is twice as slow for a scene with 10 browser sources. |
e3b65ac
to
f233a51
Compare
This is why we test, I don't know I would be able to reproduce… |
f233a51
to
535674d
Compare
Changes:
|
535674d
to
b957a0a
Compare
Just streamed for six hours with these patches, minus the NVIDIA blacklisting and it solved some framedrops when certain browser overlays would draw to the screen for me. Instead of a blacklist, can it be a warning or something? It worked really well for me. |
fe24257
to
7b44d6f
Compare
@kkartaltepe If the original test was done with CEF 103 and the test in October was done with CEF 126/127, then could this be the issue with Qt message loop (obsproject/obs-studio#11485 et al)? Or is it a separate issue? Would still like to know if this is good enough to merge, or if there's something else we need to address first. |
Testers have reported that CEF and NVIDIA driver does not seem to work well together.
7b44d6f
to
f44453f
Compare
No I think its unrelated to that. When i profiled it, graphics stuff was just really slow. |
Description
Requires:
Required by:
Add hwaccel support on Linux with CEF 6533 and later
Caution
NVIDIA might need to be blacklisted due to their inconsistency on supporting GBM and incomplete DRI3.TLDR: Only latest generations with latest driver has a likelihood to workNVIDIA driver has been blacklisted
Motivation and Context
Just wanted to try to make it somehow work for fun, ended up making it for real…
How Has This Been Tested?
Tested under Wayland and X11.
Types of changes
Checklist: