linux: Unified system info summary #177
Open
+71
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the merging of #161 Linux logs output (typically) 3 separate bullet points for the system information (Distro, Display Server, Desktop Environment), which looks odd and lengthens the page or bot summary.
Since all are merely informational and without help texts, this combines all 3 points into a single one. The Flatpak extension helptext is shown alongside it when appropriate.
For this I chose to extract the simple X11/Wayland checks into their own functions to make them reusable in other check functions.
Motivation and Context
It was noted on Discord in the
#documentation
channel that the current presentation looks - for lack of a better word - "weird" and might lead users to think that the output is bugged.Of course the output works exactly as intended because it was primarily meant for OBS Bot output. However I was thinking about shortening the OBS Bot output anyway, but at the time of the PR I just didn't think of this fairly simple solution.
How Has This Been Tested?
I used the same logs as used in #161 to check that there were no regressions in the output. Additionally I used a manually altered log to test:
Types of changes
Checklist: