Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated nvidia drivers detection #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Penwy
Copy link
Contributor

@Penwy Penwy commented Jan 25, 2025

Description

This updates the nvidia drivers check to include the new log message for it in v31.

I also took the opportunity to remove unnecessary len() calls in that file (python lists have always positive length and a list with a length of 0 has a bool value of False).

Motivation and Context

The new nvidia implementation in v31 has different behaviour with outdated drivers and wasn't getting detected.

How Has This Been Tested?

Ran analyzer on a log with outdated drivers, verified message appeared.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Penwy added 2 commits January 25, 2025 18:55
empty lists have a bool value of False in python.
Outdated driver message got changed in v31 with the nvenc refactor
@RytoEX RytoEX changed the title Update outdated nvidia drivers detection. Update outdated nvidia drivers detection Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant