Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update actions-rust-lang/setup-rust-toolchain #53

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Feb 4, 2025

Description

  1. Update actions-rust-lang/setup-rust-toolchain from v1.8.0 to v1.10.1.
    This re-enables the override option that we initially lost with moving from actions-rs/toolchain to actions-rust-lang/setup-rust-toolchain.
  2. Remove the superfluous explicit Swatinem/rust-cache usage.
    actions-rust-lang/setup-rust-toolchain includes this functionality (via Swatinem/rust-cache) by default.
  3. Rename clippy.yml to clippy.yaml to be in line with the other workflow files.

Motivation and Context

Discussed on #40. Wanted some additional cleanup and update done.

How Has This Been Tested?

My fork ran this seemingly fine:
https://github.com/RytoEX/bouf/actions/runs/13140030480

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Since actions-rust-lang/setup-rust-toolchain includes
Swatinum/rust-cache and will use it by default, we can remove the
explicit usage here.
The override option was re-added in v1.10.0 and enabled by default.
Bring the file extension in line with other files.
@RytoEX RytoEX requested a review from derrod February 4, 2025 16:47
@RytoEX RytoEX self-assigned this Feb 4, 2025
@RytoEX RytoEX changed the title Update actions-rust-lang/setup-rust-toolchain CI: Update actions-rust-lang/setup-rust-toolchain Feb 4, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@RytoEX
Copy link
Member Author

RytoEX commented Feb 26, 2025

I did see that v1.11.0 was released yesterday, but I'd like to let that sit for at least a few days before considering bumping to that.

@RytoEX RytoEX merged commit b864f94 into obsproject:master Mar 3, 2025
2 checks passed
@RytoEX RytoEX deleted the update-setup-rust-toolchain branch March 3, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant