Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): build failure when using custom native marks #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hardworker
Copy link

Build fails on importing RNPeroformance.h in Objective-C file, because chrono is a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header.

RNPerformanceEntryWasAddedNotification declaration and initialization were split to prevent build failure as well.

Build fails on importing `RNPeroformance.h` in Objective-C file, because `chrono` is a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header.

`RNPerformanceEntryWasAddedNotification` declaration and initialization were split to prevent build failure as well.
@oblador
Copy link
Owner

oblador commented Nov 7, 2023

Hi, and thanks for your PR! As this doesn't seem to be an issue for myself or others, I'm curious of your setup. Do you use a very old version of React Native? Are you using native markers along with JS based?

@hardworker
Copy link
Author

Hey, @oblador! No, I use a pretty recent 0.72 React Native. Native markers are used alongside JS ones.
However it doesn't matter how you use them, it's only about importing <react-native-performance/RNPerformance.h> in a pure Objective-C file.

Here's an example based on a clean RN template: https://github.com/hardworker/react-native-performance-test-app

@Augustach
Copy link

Hey, @oblador.
Could you please take a look at example above?

@satya164
Copy link

satya164 commented Jan 23, 2025

This is the error I get when building the app when using custom markers on iOS:

[MyApp] Compiling AppDelegate.mm
❌ /Users/name/Developer/MyAppMobile/ios/Pods/Headers/Public/react-native-performance/RNPerformance.h:2:10: 'chrono' file not found (in target 'MyApp' from project 'MyApp')
    /Users/name/Developer/MyAppMobile/ios/MyApp/main.m:4:9: note: in file included from /Users/name/Developer/MyAppMobile/ios/MyApp/main.m:4:

I applied the changes in this PR and the app builds successfully.

I'm on [email protected].

Edit: The issue seems to be fixed by renaming main.m to main.mm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants