Default optional #147
Merged
Default optional #147
+57
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfantini
commented
Mar 7, 2025
| @@ -405,7 +405,7 @@ TEST_CASE("test the encoding of fast operator default","[operator_default_encode | |||
|
|
|||
| inst.prev_value().defined(false); // reset the previous value to undefined again | |||
|
|
|||
| REQUIRE( encode_ext_cref("\xC0\x80", | |||
| REQUIRE( encode_ext_cref("\x80", | |||
There was a problem hiding this comment.
Here the unit test is checking a optional field with the default value which is not present in the value storage. And the old value encoded in the stream was \x80 (\xC0**\x80** ), which makes no sense, send a empty value.
Now it is sending only the \x80, which is the pmap only.
huangminghuang
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case of default optional, if the value storage is empty, it has not send anything in the steam.
This is correct done in the V! but not in the V2.