Group optional encoder_v2 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfantini
commented
Feb 28, 2025
martinfantini
force-pushed
the
group_encoder_error_v2
branch
from
3722572 to
bdbd32b
Compare
martinfantini
force-pushed
the
group_encoder_error_v2
branch
from
bdbd32b to
05d6f4a
Compare
martinfantini
force-pushed
the
group_encoder_error_v2
branch
from
05d6f4a to
3809d54
Compare
martinfantini
commented
Mar 3, 2025
| { | ||
| out_ << " {\n" | ||
| << " " << get_ext_cref_type(subinst) << " ext_cref_group((*this)[" << i << "]);\n" | ||
| << " ext_cref_group.set_group_present(this->field_storage(" << i << ")->is_present());\n" |
There was a problem hiding this comment.
Add the set of the group presence, at the encode time.
martinfantini
commented
Mar 3, 2025
| { | ||
| out_ << " {\n" | ||
| << " " << get_ext_cref_type(subinst) << " ext_cref_group((*this)[" << i << "]);\n" | ||
| << " ext_cref_group.set_group_present(this->field_storage(" << i << ")->is_present());\n" |
There was a problem hiding this comment.
Add the set of the group presence, at the encode time.
|
@huangminghuang Here is the solution of the optional encoding for the encoder V2, since it is not working until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Here are more unit tests, but there is a case in this unit tests , which i can not find the solution.
The case is the one you have a message with optional group. And in this case the encoder_v2 is sending data wrongly.