Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check that vnic with same name doesn't has the same network #109

Closed
wants to merge 8 commits into from
Closed

add check that vnic with same name doesn't has the same network #109

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d1442f1
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 3, 2022
8f13077
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 9, 2022
9f00269
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 10, 2022
0fbd0c1
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 10, 2022
8d94d81
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 11, 2022
75a3fdd
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 15, 2022
40ad8ec
This PR fixes #82 and check that vnic doesn't has same network
mgold1234 Feb 16, 2022
7633789
Merge branch 'main' into nic_network
mgold1234 Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mock_nic_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ func (m *mockClient) CreateNIC(
return nil, newError(ENotFound, "VM with ID %s not found for NIC creation", vmid)
}
for _, n := range m.nics {
if n.name == name {
return nil, newError(ENotFound, "NIC with name %s is already in use", name)
if n.name == name && n.vnicProfileID == vnicProfileID {
return nil, newError(ENotFound, "NIC with same name %s and same network is already in use", name)
}
}

Expand Down