add check that vnic with same name doesn't has the same network

client_nic_create_test.go

@@ -7,6 +7,8 @@ import (
 	ovirtclient "github.com/ovirt/go-ovirt-client"
 )
 
+const nicName = "test_duplicate_name"
+
 func TestVMNICCreation(t *testing.T) {
 	t.Parallel()
 	helper := getHelper(t)
@@ -29,10 +31,9 @@ func TestVMNICCreation(t *testing.T) {
 	assertNICCount(t, vm, 0)
 }
 
-func TestDuplicateVMNICCreation(t *testing.T) {
+func TestDuplicateVMNICCreationWithSameName(t *testing.T) {
 	t.Parallel()
 	helper := getHelper(t)
-	nicName := "test_duplicate_name"
 
 	vm := assertCanCreateVM(
 		t,
@@ -48,7 +49,7 @@ func TestDuplicateVMNICCreation(t *testing.T) {
 		nicName,
 		ovirtclient.CreateNICParams())
 	assertNICCount(t, vm, 1)
-	assertCannotCreateNIC(
+	assertCannotCreateNICWithSameName(
 		t,
 		helper,
 		vm,
@@ -58,3 +59,72 @@ func TestDuplicateVMNICCreation(t *testing.T) {
 	assertCanRemoveNIC(t, nic1)
 	assertNICCount(t, vm, 0)
 }
+
+func TestDuplicateVMNICCreationWithSameNameDiffVNICProfileDiffNetwork(t *testing.T) {
+	t.Parallel()
+	helper := getHelper(t)
+
+	vm := assertCanCreateVM(
+		t,
+		helper,
+		fmt.Sprintf("nic_test_%s", helper.GenerateRandomID(5)),
+		ovirtclient.CreateVMParams(),
+	)
+	assertNICCount(t, vm, 0)
+	nic1 := assertCanCreateNIC(
+		t,
+		helper,
+		vm,
+		nicName,
+		ovirtclient.CreateNICParams())
+	assertNICCount(t, vm, 1)
+	DiffVNICProfileDiffNetwork, _ := assertCanFindDiffVNICProfileDiffNetwork(helper, helper.GetVNICProfileID())
+	if DiffVNICProfileDiffNetwork == "" {
+		assertCannotCreateNICWithSameName(
+			t,
+			helper,
+			vm,
+			nicName,
+			ovirtclient.CreateNICParams())
+	} else {
+		assertCannotCreateNICWithVNICProfile(
+			t,
+			vm,
+			nicName,
+			DiffVNICProfileDiffNetwork,
+			ovirtclient.CreateNICParams())
+	}
+	assertNICCount(t, vm, 1)
+	assertCanRemoveNIC(t, nic1)
+	assertNICCount(t, vm, 0)
+}
+
+func TestDuplicateVMNICCreationWithSameNameDiffVNICProfileSameNetwork(t *testing.T) {
+	t.Parallel()
+	helper := getHelper(t)
+
+	vm := assertCanCreateVM(
+		t,
+		helper,
+		fmt.Sprintf("nic_test_%s", helper.GenerateRandomID(5)),
+		ovirtclient.CreateVMParams(),
+	)
+	assertNICCount(t, vm, 0)
+	nic1 := assertCanCreateNIC(
+		t,
+		helper,
+		vm,
+		nicName,
+		ovirtclient.CreateNICParams())
+	assertNICCount(t, vm, 1)
+	DiffVNICProfileSameNetwork, _ := assertCanFindDiffVNICProfileSameNetwork(t, helper, helper.GetVNICProfileID())
+	assertCannotCreateNICWithVNICProfile(
+		t,
+		vm,
+		nicName,
+		DiffVNICProfileSameNetwork,
+		ovirtclient.CreateNICParams())
+	assertNICCount(t, vm, 1)
+	assertCanRemoveNIC(t, nic1)
+	assertNICCount(t, vm, 0)
+}

client_nic_test.go

@@ -34,19 +34,33 @@ func assertCanCreateNIC(
 	return nic
 }
 
-func assertCannotCreateNIC(
+func assertCannotCreateNICWithSameName(
 	t *testing.T,
 	helper ovirtclient.TestHelper,
 	vm ovirtclient.VM,
 	name string,
 	params ovirtclient.BuildableNICParameters,
 ) {
-	nic, _ := vm.CreateNIC(name, helper.GetVNICProfileID(), params)
-	if nic != nil {
+
+	_, err := vm.CreateNIC(name, helper.GetVNICProfileID(), params)
+	if err == nil {
 		t.Fatalf("create 2 NICs with same name %s", name)
 	}
 }
 
+func assertCannotCreateNICWithVNICProfile(
+	t *testing.T,
+	vm ovirtclient.VM,
+	name string,
+	diffVNICProfile string,
+	params ovirtclient.BuildableNICParameters,
+) {
+	_, err := vm.CreateNIC(name, diffVNICProfile, params)
+	if err == nil {
+		t.Fatalf("create 2 NICs with same name %s and different VNICProfile (%v)", name, err)
+	}
+}
+
 func assertCanRemoveNIC(t *testing.T, nic ovirtclient.NIC) {
 	if err := nic.Remove(); err != nil {
 		t.Fatalf("failed to remove NIC %s (%v)", nic.ID(), err)

client_vnicprofile_test.go

@@ -55,3 +55,38 @@ func assertCanCreateVNICProfile(t *testing.T, helper ovirtclient.TestHelper) ovi
 		})
 	return newVNICProfile
 }
+
+func assertCanFindDiffVNICProfileDiffNetwork(helper ovirtclient.TestHelper, vnicProfileID string) (string, error) {
+	client := helper.GetClient()
+	existVNICProfile, err := client.GetVNICProfile(vnicProfileID)
+	if err != nil {
+		return "", fmt.Errorf("failed to verify VNIC profile ID %s", vnicProfileID)
+	}
+	networkID := existVNICProfile.NetworkID()
+	vnicProfiles, err := client.ListVNICProfiles()
+	if err != nil {
+		return "", fmt.Errorf("failed to list VNIC profiles (%w)", err)
+	}
+	for _, vnicProfile := range vnicProfiles {
+		vnicID := vnicProfile.ID()
+		if vnicID != vnicProfileID && vnicProfile.NetworkID() != networkID {
+			return vnicID, nil
+		}
+	}
+	return "", fmt.Errorf(
+		"failed to find different VNIC profile ID and Different Network for testing, use the exiting one")
+}
+
+func assertCanFindDiffVNICProfileSameNetwork(t *testing.T, helper ovirtclient.TestHelper, vnicProfileID string) (string, error) {
+	client := helper.GetClient()
+	newVNICProfile := assertCanCreateVNICProfile(t, helper)
+	existVNICProfile, err := client.GetVNICProfile(vnicProfileID)
+	if err != nil {
+		return "", fmt.Errorf("failed to verify VNIC profile ID %s", vnicProfileID)
+	}
+	if newVNICProfile.NetworkID() == existVNICProfile.NetworkID() {
+		return newVNICProfile.ID(), nil
+	}
+	return "", fmt.Errorf(
+		"failed to find different VNIC profile ID and same Network for testing, use the exiting one")
+}

mock_nic_create.go

@@ -22,7 +22,7 @@ func (m *mockClient) CreateNIC(
 	}
 	for _, n := range m.nics {
 		if n.name == name {
-			return nil, newError(ENotFound, "NIC with name %s is already in use", name)
+			return nil, newError(ENotFound, "NIC with same name %s is already in use", name)
 		}
 	}