-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[event.schema.json]: remove click_through #19
base: main
Are you sure you want to change the base?
Conversation
I agree - a click through is just a click. |
Agreed - I'd consider adding "impression" to the enum to make it a bit more clear on how clickthrough rate could be calculated. |
@miike That might be the purpose of |
I think depending on the vertical they might mean distinct things (e.g., for ecommerce a page view of the PDP page would be a view versus a tile impression in search results). It's probably not particularly important but just depends on how opinionated you want the enum to be. |
@miike would you be interested in submitting |
Sure thing - I've done that in #22 |
I am going to leave this one open a bit longer, and the reason is that the "specific connotations in advertising" is kind of what makes this potentially REALLY valuable. Those same connotations also apply to very common search use cases. I did a search and I am clicking through to this detail page.... I don't see merging this materially as making the 1.1 release worse, so I'd like to leave this open for more discussion and try and get it decided for 1.2. |
This is a minor change. I think we should remove the
enum
valueclick_through
as that indicates a subset ofclick
and has specific connotations in advertising.