Adds support for using hifitime in WASM targets

[thomasantony]

std::time::SystemClock::now() does not work in the browser. The instant provides an alternative that works in the browser and falls back to std::time::SystemClock on non-WASM targets. I have added a new web feature flag that enables the extra features from the instant crate.

This is required for running the ANISE gui in the browser.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b731275) 80.67% compared to head (85af13f) 80.74%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   80.67%   80.74%   +0.06%     
==========================================
  Files          15       16       +1     
  Lines        3746     3754       +8     
==========================================
+ Hits         3022     3031       +9     
+ Misses        724      723       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristopherRabotin]

Since the instant crate has not been updated since October 2018, uses the 2018 edition of Rust, and since SystemTime is only referenced twice I have an itch to just snatch the small amount of relevant code from that crate (BSD-3, so no license issue there), and skip using the crate all together.

I'll have a look at doing this over the weekend.

[thomasantony]

@ChristopherRabotin I have moved over what I think is the minimal amount of code to get things going. The instant crate had a bunch of compile-time options that seemed to be about using the different web-runtimes. I copied over just the one for wasm-bindgen as that seems to be the most widely used one at this point (and that is what I compiled ANISE with).

The new dependencies are restricted to wasm targets.

[ChristopherRabotin]

Great work, this is exactly what I was asking for. I just have a few comments to use the Unit time in hifitime for the unit conversion from seconds to a Duration structure, and that should be good to merge.

[ChristopherRabotin]

Suggested change

	.as_secs_f64() * 1000.0
	.as_secs_f64() * Unit::Second

By using the Unit enum, the now() function would directly return a Duration, so the function could be directly duration_since_unix_epoch() I think.

[thomasantony]

Great idea! I have refactored system_time:: duration_since_unix_epoch() to directly return hifitime::Duration

[ChristopherRabotin]

Should this import be moved into the now() function on line 16?

[thomasantony]

It is also used in the return type for duration_since_unix_epoch

No longer relevant as I am now using hifitime::Duration

[ChristopherRabotin]

Ah, this needs to be "from unix duration" now, otherwise it assumes that the reference epoch is J1900 (the TAI ref epoch), but unix seconds are wrt 01 January 1970

[thomasantony]

I could not find a from_unix_duration(). Should I add it?

[ChristopherRabotin]

Ah, right, seems like it's only on the version 4 development branch. Just call the from unix seconds : https://docs.rs/hifitime/latest/hifitime/struct.Epoch.html#method.from_unix_seconds

…

On Sat, Dec 9, 2023, 23:19 Thomas Antony ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/epoch.rs <#262 (comment)>: > pub fn now() -> Result<Self, Errors> { - match SystemTime::now().duration_since(SystemTime::UNIX_EPOCH) { - Ok(std_duration) => Ok(Self::from_unix_seconds(std_duration.as_secs_f64())), - Err(_) => Err(Errors::SystemTimeError), - } + let duration = crate::system_time::duration_since_unix_epoch()?; I could not find a from_unix_duration(). Should I add it? — Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEZV2AS6RSUO57QSFVADJDYIVH6DAVCNFSM6AAAAABAIYSNUWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZTHE3TEMRSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[thomasantony]

Ah, right, seems like it's only on the version 4 development branch. Just call the from unix seconds : https://docs.rs/hifitime/latest/hifitime/struct.Epoch.html#method.from_unix_seconds
…
On Sat, Dec 9, 2023, 23:19 Thomas Antony @.> wrote: @.* commented on this pull request. ------------------------------ In src/epoch.rs <#262 (comment)>: > pub fn now() -> Result<Self, Errors> { - match SystemTime::now().duration_since(SystemTime::UNIX_EPOCH) { - Ok(std_duration) => Ok(Self::from_unix_seconds(std_duration.as_secs_f64())), - Err(_) => Err(Errors::SystemTimeError), - } + let duration = crate::system_time::duration_since_unix_epoch()?; I could not find a from_unix_duration(). Should I add it? — Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZV2AS6RSUO57QSFVADJDYIVH6DAVCNFSM6AAAAABAIYSNUWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZTHE3TEMRSGI . You are receiving this because you were mentioned.Message ID: @.***>

I created a from_unix_duration(). See my latest commit.

[ChristopherRabotin]

Looks good, thank you