Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse error serialisation #420

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Aug 27, 2024

Convert parse errors into strings manually to avoid JSON serialisation failure due to circular references.

Fixes #406

Copy link

github-actions bot commented Aug 27, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ DOCKERFILE hadolint 1 0 0.05s
✅ GROOVY npm-groovy-lint 10 3 0 19.2s
✅ JAVASCRIPT prettier 98 98 0 3.82s
✅ JSON jsonlint 8 0 0.17s
✅ JSON npm-package-json-lint yes no 0.51s
✅ JSON prettier 8 3 0 0.83s
✅ JSON v8r 8 0 18.45s
✅ MARKDOWN markdownlint 7 2 0 3.53s
✅ MARKDOWN markdown-table-formatter 7 5 0 0.75s
✅ REPOSITORY checkov yes no 16.99s
✅ REPOSITORY gitleaks yes no 5.26s
✅ REPOSITORY git_diff yes no 0.15s
✅ REPOSITORY grype yes no 17.72s
✅ REPOSITORY secretlint yes no 1.84s
✅ REPOSITORY trivy yes no 9.36s
✅ REPOSITORY trivy-sbom yes no 1.18s
✅ REPOSITORY trufflehog yes no 8.3s
✅ SPELL cspell 129 0 5.57s
✅ SPELL lychee 18 0 2.76s
✅ XML xmllint 1 0 0 0.12s
✅ YAML prettier 3 0 0 0.55s
✅ YAML v8r 3 0 7.58s
✅ YAML yamllint 3 0 0.26s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@stevenh
Copy link
Collaborator Author

stevenh commented Aug 28, 2024

Looks like this causes issues with tests, so needs more work

@stevenh stevenh marked this pull request as draft August 28, 2024 00:21
Convert parse errors into strings manually to avoid JSON serialisation
failure due to circular references.

Fixes #406
@stevenh stevenh force-pushed the fix/parse-error-serialisation branch from ebe6662 to 611af44 Compare August 28, 2024 20:10
@stevenh stevenh marked this pull request as ready for review August 28, 2024 20:33
@stevenh stevenh requested a review from nvuillam August 28, 2024 20:33
@nvuillam
Copy link
Owner

@stevenh I don't know what happens with codecov token (I generated a new one, but same strange result) , i'm ok to disable this part of the workflow :)

@echoix
Copy link

echoix commented Aug 28, 2024

The step is also set with dry run true, so it won't upload anyways.

@echoix
Copy link

echoix commented Aug 28, 2024

It seems that there are at least some users that works and fails randomly : codecov/codecov-action#1548

@stevenh
Copy link
Collaborator Author

stevenh commented Aug 29, 2024

As those failures not connected with PR will look to merge once your review is in @nvuillam.

@nvuillam nvuillam merged commit fef3dc2 into main Aug 29, 2024
22 of 24 checks passed
@nvuillam nvuillam deleted the fix/parse-error-serialisation branch August 29, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants