-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make .nvmrc
more versatile/modular
#3235
Draft
victormihalache
wants to merge
11
commits into
nvm-sh:master
Choose a base branch
from
victormihalache:issue3234
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR was premature pending discussion on the issue; I don't value "less config files in the root", and thus the added complexity to nvm is unlikely to be worth it to me (the only maintainer). Let's continue discussion on the issue.
ljharb
force-pushed
the
master
branch
2 times, most recently
from
June 10, 2024 18:13
c6cfc3a
to
c20db2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made because of #3234.
As of opening this PR the only difference is that a new
--config=
flag can be used to indicate the path to the.nvmrc
(or any other name for that matter) to be used specifically. It is available to all commands that utilize the.nvmrc
file to begin with, those being:install
,use
,exec
,run
,which
. I have tested all of them using the docker container provided.What I want to add next are the following features:
.nvmrc
file if the path is to a folder, rather than a file..nvmrc
in the root.I would also love to hear the thoughts of @ljharb and other maintainers, but also general users of nvm!