Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions to build and test NVDA #17728

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

nvdaes
Copy link
Collaborator

@nvdaes nvdaes commented Feb 23, 2025

  • Update scripts
  • Update until scons source
  • Update to prepare for tests
  • Update until install NVDA
  • Try to fix install NVDA by changing path
  • Install NVDA: cd output before
  • Install NVDA: .. before ps1 file
  • Install NVDA: try to fix path for output NVDA
  • Install NVDA: install script in workflows directory
  • Install NVDA: include .github/workflows in script path
  • Install NVDA: cd output inside powershell script
  • Install NVDA: rename nvda
  • Install NVDA fix syntax
  • Install NVDA fix syntax 2
  • Install NVDA: move install script to root
  • Install NVDA: fix path for script
  • Install NVDA from cmd
  • Install NVDA: try to fix path to instaLLNVDA.ps1
  • Try to save installNVDA file
  • Install NVDA: cd output before installing
  • Install NVDA: format nvdaLauncherFile in workflow
  • Install NVDA: fix syntax
  • Install NVDA: echo nvdaLaunchFile
  • Fix variable
  • Install NVDA: try to use powershell script again
  • Install NVDA: quotations for command
  • Install NVDA: try to run launcher file
  • Install NVDA: use separated step to set launcher file
  • Install NVDA: test renaming file to nvda.exe
  • Dir in output
  • Run launcher in separated step
  • Try to run launchet, not sconsOutTargets
  • Checkout submodules recursively
  • Run launcher just with version
  • Fix workflow
  • Install NVDA with installNVDA.ps1
  • Fix: remove versionType to scons launcher
  • Try to run system tests
  • Run system tests
  • Fix workflow

Link to issue number:

fixes #10516

Summary of the issue:

Currently Appveyor is used to build and test NVDA. GitHub Actions may be preferred, since it's on GitHub and may be easier to use.

Description of user facing changes

None

Description of development approach

  • Used variables available for GitHub Actions instead of Appveyor variables.
  • When appropriate, powershel scripts used for appveyor continuous integrations are used here.
    Note: Work in progress, not finished.

Testing strategy:

Tested in nvdaes GitHub fork.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@nvdaes nvdaes changed the title githubActions Use GitHub Actions to build and test NVDA Feb 23, 2025
@AppVeyorBot
Copy link

  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit ac008495eb

@AppVeyorBot
Copy link

  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 73bfa0bf5c

@AppVeyorBot
Copy link

  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 44cfa0d95b

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to use GitHub Actions to build NVDA
3 participants