Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined Chinese character descriptions and added entries for ancient characters and tongjiazi (phonetic loan characters). #17727

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

cary-rowen
Copy link
Contributor

Link to issue number:

None

Summary of the issue:

For Chinese, the characterDescriptions.dic file has been updated to refine existing descriptions and add more entries for ancient characters and tongjiazi (phonetic loan characters).

Description of user facing changes

The Chinese character description has been updated to provide more Chinese character descriptions.

Description of development approach

The characterDescriptions.dic file has been updated to refine existing descriptions and add more entries for ancient characters and tongjiazi (phonetic loan characters).

Testing strategy:

Manual testing

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

…characters and tongjiazi (phonetic loan characters).
@cary-rowen cary-rowen requested a review from a team as a code owner February 23, 2025 10:42
@cary-rowen
Copy link
Contributor Author

The simplified Chinese character descriptions are mainly maintained by Alan and I hope to mention his contributions here.

Many Thanks, cc @Alan86024

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Feb 24, 2025
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cary-rowen !

@seanbudd seanbudd merged commit cde7967 into nvaccess:master Feb 25, 2025
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants