Excel: fix comments/formulas listing (NVDA+f7) when they are in non-contiguous cells
#17720
+25
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending triage of #11366 |
seanbudd
approved these changes
Feb 25, 2025
| @@ -263,7 +264,7 @@ This is a patch release to fix a bug when saving speech symbol dictionaries. | |||
|
|
|||
| * Fixed bug where speech symbols dictionaries were not saved and the dialog would not be closed. (#17344) | |||
|
|
|||
| ## 2024.4 | |||
| e## 2024.4 | |||
There was a problem hiding this comment.
Suggested change
| e## 2024.4 | |
| ## 2024.4 |
| for index in range(numCellsFetched.value): | ||
| ci = cellInfos[index] | ||
| if not ci.address: | ||
| log.debugWarning("cellInfo at index %s has no address" % index) |
There was a problem hiding this comment.
Suggested change
| log.debugWarning("cellInfo at index %s has no address" % index) | |
| log.debugWarning(f"cellInfo at index {index} has no address") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11366
Summary of the issue:
In an Excel sheet, when comments or formulas are located in non-contiguous cells (i.e. most of the time), listing them in the elements dialog (
NVDA+f7) fails.It's because our cpp code only support ranges containing one area.
Description of user facing changes
Excel will no longer fail to list formulas/comments in its elements dialog when
Description of development approach
Added one extra loop to retrieve the content for each area separately.
Testing strategy:
Manual test for comments, formulas in non-contiguous cells.
Tested on:
If someone wants to test on other office versions (e.g. 365, or older ones) feel free to provide feedback. Thanks.
Known issues with pull request:
None
Additional note
I had this code in a branch for many years now.
Maybe we could work on a more optimized architecture if we can convert the cpp code to handle multiple areas.
However, I am not sure to have time or to be able to dig into this.
Since #11366 has not been addressed for so many years, I made the decision to provide my code as is. If we notice performances issues in the future, we still can think to optimize the architecture trying to retrieve the information for the cells of all areas in one call to the cpp code.
Code Review Checklist:
@coderabbitai summary