Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on Store: Download without duplicates to override incompatibilities. #17717

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

hwf1324
Copy link
Contributor

@hwf1324 hwf1324 commented Feb 21, 2025

Link to issue number:

Fixed #17655

Summary of the issue:

When there is an error downloading an Add-on that overrides an incompatibility, retrying the download will encounter an error. The reason for this is that the exception thrown when overriding incompatibilities is not handled for duplicates.

Description of user facing changes

The download can now be retried to override the incompatible Add-on.

No changelog is required for this PR as the Retry Download Add-on was introduced in 2025.1.

Description of development approach

Determine if an incompatibility has been overridden before overriding it.

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@hwf1324 hwf1324 requested a review from a team as a code owner February 21, 2025 01:38
@hwf1324 hwf1324 requested a review from SaschaCowley February 21, 2025 01:38
@AppVeyorBot
Copy link

  • PASS: Translation comments check.
  • PASS: License check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 4d70b5508e

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Feb 25, 2025
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hwf1324

@seanbudd seanbudd closed this Feb 25, 2025
@seanbudd seanbudd reopened this Feb 25, 2025
@seanbudd seanbudd merged commit 8400918 into nvaccess:master Feb 25, 2025
7 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Feb 25, 2025
@hwf1324 hwf1324 deleted the fix17655 branch February 25, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-on Store: after installation of an incompatible Add-on fails. Unable to retry installation.
3 participants