Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually refresh the recognized content with NVDA+f5 in a recognition result #17715

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Feb 20, 2025

Link to issue number:

None

Summary of the issue:

Even if not using the automatic refresh of the content recognition, the user may want to update the recognized content once manually. Today, they needs to close the recog result and perform a recognition again.

Description of user facing changes

In a result of content recognition, the user can now press NVDA+f5 to refresh the result of recognized content. This refresh gesture is the same as the one to refresh the content of virtual buffers.

Description of development approach

In RefreshableRecogResultNVDAObject, added a script to refresh the recognition result. If automatic recognition is enabled, the script reports an error message.

Testing strategy:

Manual test of the script with and without auto-refresh enabled.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@AppVeyorBot
Copy link

  • PASS: Translation comments check.
  • PASS: License check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 3073ea0186

@CyrilleB79 CyrilleB79 marked this pull request as ready for review February 20, 2025 12:00
@CyrilleB79 CyrilleB79 requested review from a team as code owners February 20, 2025 12:00
@CyrilleB79 CyrilleB79 changed the title Manually refresh the recognized content with f5 in a recognition result Manually refresh the recognized content with NVDA+f5 in a recognition result Feb 20, 2025
@AppVeyorBot
Copy link

  • PASS: Translation comments check.
  • PASS: License check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit 5a83e133c5

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Feb 25, 2025
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well (with Sean's suggestion)

@seanbudd seanbudd merged commit 287a045 into nvaccess:master Feb 25, 2025
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Feb 25, 2025
seanbudd pushed a commit that referenced this pull request Feb 25, 2025
…on result (#17715)

Summary of the issue:
Even if not using the automatic refresh of the content recognition, the user may want to update the recognized content once manually. Today, they needs to close the recog result and perform a recognition again.

Description of user facing changes
In a result of content recognition, the user can now press NVDA+f5 to refresh the result of recognized content. This refresh gesture is the same as the one to refresh the content of virtual buffers.

Description of development approach
In RefreshableRecogResultNVDAObject, added a script to refresh the recognition result. If automatic recognition is enabled, the script reports an error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants