Fix scrolling to anchor links pointing to the object containing the virtual caret #17676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17669
Summary of the issue:
When anchor links point to the objec where the virtual caret is placed, NVDA doesn't scroll to the link destination.
Description of user facing changes
NVDA Will scroll to destination of anchor links, even where they point to the object where the virtual caret is placed.
Description of development approach
In the
_handleScrollTo
function of source/browseMode.py, we check if the caret is placed in the same line as the anchor link destination, instead of checking if it's in the same object.This has been explained and suggested by @jcsteh in #17669.
Testing strategy: placed in the same object.
Tested with Firefox on Windows 11, and with Chrome and Edge, with and without UIA enabled, using the demo provided in #17669
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary