Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poedit reports text such as context or errors when focused #17166

Closed
wants to merge 4 commits into from
Closed

Poedit reports text such as context or errors when focused #17166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbb275f
Poedit reports text such as context or errors when focused
CyrilleB79 Sep 13, 2024
39b0f7f
Add PR number in change log
CyrilleB79 Sep 13, 2024
7f34324
Pre-commit auto-fix
pre-commit-ci[bot] Sep 13, 2024
8a04f6a
Merge branch 'master' into poeditTxt
CyrilleB79 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions source/appModules/poedit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ def chooseNVDAObjectOverlayClasses(self, obj, clsList):
and obj.windowClassName == "RICHEDIT50W"
):
clsList.insert(0, PoeditRichEdit)
elif obj.role == controlTypes.Role.PANE and obj.windowClassName == "wxWindowNR":
clsList.insert(0, PoeditPane)


class PoeditRichEdit(NVDAObject):
Expand Down Expand Up @@ -289,3 +291,14 @@ def reportFocus(self):
tones.beep(550, 50)
case _WindowControlId.NEEDS_WORK_SWITCH:
tones.beep(660, 50)


class PoeditPane(NVDAObject):
def _get_focusRedirect(self):
try:
obj = self.firstChild.firstChild
if obj:
return obj
except AttributeError:
pass
return None
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Specifically, MathML inside of span and other elements that have the attribute `
* In Notepad and other UIA documents, and Notepad++ documents on Windows 11, if the last line is empty, the "braille next line command" will move the cursor to the last line.
In any document, if the cursor is on the last line, it will be moved to the end when using this command.
(#17251, #17430, @nvdaes)
* Details such as context or errors will now be correctly reported during navigation in poedit. (#17166, @CyrilleB79)

### Changes for Developers

Expand Down