Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTubePlayer): adjust thumbnail ratio to 640x360 #310

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

maximepvrt
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This MR updates the default thumbnail format for YouTube videos to 640x360 (16:9), removing black bars that appeared in the previous sddefault preview (640x480), due to an incorrect aspect ratio.

Main Changes:

  • Default Format: Changed from 640x480 to 640x360 to maintain a 16:9 aspect ratio. https://support.google.com/youtube/answer/6375112
  • Removal of Black Bars: The new format displays thumbnails without the black bars at the top and bottom, providing a cleaner and more immersive preview.

Impact:

  • Front-end thumbnails will now adhere to the standard 16:9 aspect ratio, improving visual consistency and aesthetic appeal.

Copy link

vercel bot commented Oct 28, 2024

@maximepvrt is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@maximepvrt
Copy link
Contributor Author

@harlan-zw :-)

@harlan-zw
Copy link
Collaborator

Thanks for the PR, this is the right direction.

Given that it's partially breaking, we should wait for the minor to release it which I have a few other things I want to batch in. Sorting this one would be good to go with this #235

Will merge for now.

@harlan-zw harlan-zw changed the title feat: Adjust YouTube thumbnail ratio to 640x360 feat(YouTubePlayer): Adjust YouTube thumbnail ratio to 640x360 Nov 12, 2024
@harlan-zw harlan-zw changed the title feat(YouTubePlayer): Adjust YouTube thumbnail ratio to 640x360 feat(YouTubePlayer): adjust thumbnail ratio to 640x360 Nov 12, 2024
@harlan-zw harlan-zw merged commit 8f84640 into nuxt:main Nov 12, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants