Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: restructureDir defaults #3106

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The defaults for restructureDir were not being used correctly, I realised this was the case because the existing tests should have been failing πŸ˜… I have also added the option to disable the feature temporarily for v9 by being able to set restructureDir to false.

I think after merging this it's time to have a new alpha or beta release, I think a release candidate is not far away.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Sep 17, 2024
@BobbieGoede
Copy link
Collaborator Author

Oops this also includes changes to the playground, removing those

@BobbieGoede BobbieGoede marked this pull request as draft September 17, 2024 13:54
@BobbieGoede BobbieGoede marked this pull request as ready for review September 17, 2024 13:58
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@kazupon kazupon merged commit 3e33699 into nuxt-modules:main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants