fix: custom child route localization #2743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Linked issue
โ Type of change
๐ Description
Resolves #2351
Based on debugging this, I think we may be able to improve this functionality in the future. Currently we expect users to supply a full localized path the a child route using
defineI18nRoute
orpages
in config (e.g./parent/child
), it would be better if users only have to provide localization for the child path segment (e.g./child
orchild
). This way the parent route could be renamed or the child route could be moved without having to update the custom route localization in multiple files.๐ Checklist