Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add basic github pipeline (#12) #14

Merged
merged 15 commits into from
Aug 26, 2020

Conversation

NetBKarine
Copy link

@NetBKarine NetBKarine commented Aug 25, 2020

Description

Added two jobs to run linting and tests on core and action-server, on pull requests and master.
Added a phony test to core because everything (dev-dependencies and all) is there to write tests, so might as well include it in the workflow in case we decide to add real ones without without thinking of the checks...

Related issues

closes #12

Checklist

  • PR title follows Conventional Commits guidelines
  • All relevant PR sections are populated, irrelevant ones are removed

@NetBKarine NetBKarine force-pushed the chore-add-github-pipeline-12 branch from abdd0fe to a84797a Compare August 25, 2020 18:40
@NetBKarine NetBKarine force-pushed the chore-add-github-pipeline-12 branch from a84797a to b38c038 Compare August 25, 2020 18:43
@NetBKarine NetBKarine closed this Aug 25, 2020
@NetBKarine NetBKarine reopened this Aug 25, 2020
@NetBKarine NetBKarine requested a review from fparga August 25, 2020 19:50
.github/workflows/check.yml Outdated Show resolved Hide resolved
core/tests/test_nothing.py Show resolved Hide resolved
.github/workflows/check.yml Outdated Show resolved Hide resolved
@fparga
Copy link
Member

fparga commented Aug 25, 2020

You can also delete the .circleci folder

@NetBKarine NetBKarine requested a review from fparga August 26, 2020 13:51
.github/actions/setup-poetry/action.yml Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
@NetBKarine NetBKarine merged commit 3d0444d into master Aug 26, 2020
@NetBKarine NetBKarine deleted the chore-add-github-pipeline-12 branch August 26, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub workflow
2 participants