Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbtcv2 arg compat fix #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

vepkenez
Copy link
Contributor

@vepkenez vepkenez commented Dec 31, 2023

Type of PR:

  • Bugfix

Required reviews:

  • 1
  • 2
  • 3

What this does:
Found a bug when doing: nucypher-ops tbtcv2 run
the arg name mismatch was causing an Ansible "this variable does not exist" error.
Deployment failed. This patch allows it to succeed with no additional changes.

this commit was made for Ursula:
https://github.com/nucypher/nucypher-ops/blame/326e2918ff583bb5a11bb097ea9737720d00fd3d/nucypher_ops/templates/ursula_inventory.mako#L36

This PR does the same for tbtcv2 and Porter

@derekpierre
Copy link
Member

Great to see you again @vepkenez ! 🤗 Thanks for the fix.

Just as an aside, admittedly, we are trying to wind down the use of nucypher-ops. It's a lot of maintenance and it breeds a measure of complacency for node operators with nucypher-ops handling much of the operational key/secrets management for them; not necessarily a good thing given the increased sensitivity of material used for tBTC and TACo. We want node operators to actively understand what they are doing (instead of passively), and what needs to be backed up and kept secret. This also ties in with the node set up process being much more simple than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants