Extract role to approve fee model

nucypher · Jan 28, 2025 · 5893d61 · 5893d61
1 parent 941cd34
commit 5893d61
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/contracts/contracts/coordination/Coordinator.sol b/contracts/contracts/coordination/Coordinator.sol
@@ -93,6 +93,7 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable
     }
 
     bytes32 public constant TREASURY_ROLE = keccak256("TREASURY_ROLE");
+    bytes32 public constant FEE_MODEL_MANAGER_ROLE = keccak256("FEE_MODEL_MANAGER_ROLE");
 
     ITACoChildApplication public immutable application;
     uint96 private immutable minAuthorization; // TODO use child app for checking eligibility
@@ -646,7 +647,7 @@ contract Coordinator is Initializable, AccessControlDefaultAdminRulesUpgradeable
         }
     }
 
-    function approveFeeModel(IFeeModel feeModel) external onlyRole(TREASURY_ROLE) {
+    function approveFeeModel(IFeeModel feeModel) external onlyRole(FEE_MODEL_MANAGER_ROLE) {
         require(!feeModelsRegistry[feeModel], "Fee model already approved");
         feeModelsRegistry[feeModel] = true;
         emit FeeModelApproved(feeModel);

diff --git a/tests/test_coordinator.py b/tests/test_coordinator.py
@@ -81,8 +81,9 @@ def fee_model(project, deployer, coordinator, erc20, treasury):
     contract = project.FlatRateFeeModel.deploy(
         coordinator.address, erc20.address, FEE_RATE, sender=deployer
     )
-    coordinator.grantRole(coordinator.TREASURY_ROLE(), treasury, sender=deployer)
+    coordinator.grantRole(coordinator.FEE_MODEL_MANAGER_ROLE(), treasury, sender=deployer)
     coordinator.approveFeeModel(contract.address, sender=treasury)
+    coordinator.grantRole(coordinator.TREASURY_ROLE(), treasury, sender=deployer)
     return contract