Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MqttService::connect_timeout() only for reading protocol version #167

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

fafhrd91
Copy link
Member

@fafhrd91 fafhrd91 commented Mar 7, 2024

No description provided.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 41.30435% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 66.30%. Comparing base (480b8ef) to head (055f5f8).

Files Patch % Lines
src/server.rs 53.57% 13 Missing ⚠️
src/v5/router.rs 0.00% 9 Missing ⚠️
src/v3/router.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files          53       53           
  Lines        9371     9325   -46     
=======================================
- Hits         6213     6183   -30     
+ Misses       3158     3142   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 merged commit 6ec3649 into master Mar 11, 2024
14 of 21 checks passed
@fafhrd91 fafhrd91 deleted the connect-timeout branch March 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant