Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README announcement to indicate release of v3 🎉 #791

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

trey-stafford
Copy link
Contributor

Description

Title! Closes #788

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated (for user-facing changes)
  • Documentation updated if needed
  • New unit tests if needed

README.md Outdated
> [alpha release announcement](https://github.com/nsidc/qgreenland/discussions/694)
> for more details, including highlights of this release.
> :tada: QGreenland v3 has been released! Please visit our
> [website](https://qgreenland.org/download) to download it now!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change to a getting started page that then links directly to the download in the new website. Maybe we should just link to the package here instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent here. If they're on GitHub, they may want to go directly to the package. But if we link to the website, which links to the package, we only need to keep the package link updated in one place.

README.md Outdated
> [alpha release announcement](https://github.com/nsidc/qgreenland/discussions/694)
> for more details, including highlights of this release.
> :tada: QGreenland v3 has been released! Please visit our
> [website](https://qgreenland.org/download) to download it now!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm indifferent here. If they're on GitHub, they may want to go directly to the package. But if we link to the website, which links to the package, we only need to keep the package link updated in one place.

@trey-stafford trey-stafford merged commit 0d710d9 into main Aug 28, 2023
2 checks passed
@trey-stafford trey-stafford deleted the update-annoucement branch August 28, 2023 16:48
@MattF-NSIDC MattF-NSIDC changed the title Update README annoucement to indicate release of v3 🎉 Update README announcement to indicate release of v3 🎉 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README to reflect v3 release
2 participants