Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 38 #63

Merged
merged 27 commits into from
Oct 9, 2024
Merged

Issue 38 #63

merged 27 commits into from
Oct 9, 2024

Conversation

eigenbeam
Copy link
Contributor

No description provided.

@eigenbeam eigenbeam linked an issue Sep 18, 2024 that may be closed by this pull request
Posting CNM message to Kinesis #38
Closed
@eigenbeam eigenbeam marked this pull request as ready for review September 19, 2024 23:51
juliacollins
juliacollins reviewed Sep 30, 2024
View reviewed changes
scripts/env.sh Show resolved Hide resolved
scripts/env.sh Show resolved Hide resolved
juliacollins
juliacollins requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@juliacollins juliacollins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know how (or if) you want me to deal with the confusion I injected with my work on issue-36. Dealing with boolean values in an .ini value needs to happen in this PR, not as part of issue-36. :-(

src/nsidc/metgen/config.py Show resolved Hide resolved
src/nsidc/metgen/metgen.py Outdated Show resolved Hide resolved
juliacollins
juliacollins requested changes Oct 9, 2024
View reviewed changes
src/nsidc/metgen/metgen.py Outdated Show resolved Hide resolved
src/nsidc/metgen/metgen.py Outdated Show resolved Hide resolved
src/nsidc/metgen/metgen.py Outdated Show resolved Hide resolved
src/nsidc/metgen/config.py Outdated Show resolved Hide resolved
@eigenbeam eigenbeam merged commit 5c08aa8 into main Oct 9, 2024
1 check passed
@eigenbeam eigenbeam deleted the issue-38 branch October 9, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliacollins juliacollins juliacollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Posting CNM message to Kinesis
2 participants
@eigenbeam @juliacollins