Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nx-dev): powerpack landing page #27963

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat(nx-dev): powerpack landing page #27963

merged 2 commits into from
Sep 25, 2024

Conversation

juristr
Copy link
Member

@juristr juristr commented Sep 17, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 25, 2024 10:42pm

@juristr juristr self-assigned this Sep 17, 2024
@juristr juristr marked this pull request as draft September 17, 2024 21:00
@juristr juristr added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Sep 17, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 17, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 642f804. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

isaacplmann
isaacplmann reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think Powerpack should be described as extensions to the Nx CLI and not just Nx. That makes it clearer what the distinction is between Powerpack and Nx Cloud.
  • Amazon refers to their S3 product as Amazon S3 not AWS S3
  • A few typo fixes

nx-dev/nx-dev/app/powerpack/page.tsx Outdated
export const metadata: Metadata = {
title: 'Nx PowerPack',
description:
'Nx PowerPack is a suite of advanced tools designed for enterprise use cases.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Nx PowerPack is a suite of advanced tools designed for enterprise use cases.',
'Nx PowerPack is a suite of paid extensions for the Nx CLI specifically designed for enterprises.',

nx-dev/nx-dev/app/powerpack/page.tsx Outdated
url: 'https://nx.dev/powerpack',
title: 'Nx PowerPack',
description:
'Nx PowerPack is a suite of advanced tools designed for enterprise use cases.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Nx PowerPack is a suite of advanced tools designed for enterprise use cases.',
'Nx PowerPack is a suite of paid extensions for the Nx CLI specifically designed for enterprises.',

nx-dev/ui-common/src/lib/headers/menu-items.ts Outdated
{
name: 'Nx Powerpack',
description:
'A suite of paid extensions for Nx specifically designed for enterprises.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'A suite of paid extensions for Nx specifically designed for enterprises.',
'A suite of paid extensions for the Nx CLI specifically designed for enterprises.',

nx-dev/ui-powerpack/src/lib/get-started.tsx Outdated
href="#workspace-conformance"
title="Workspace conformance"
>
wokrspace conformance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wokrspace conformance
workspace conformance

nx-dev/ui-powerpack/src/lib/hero.tsx Outdated
Nx Powerpack
</SectionHeading>
<SectionHeading as="p" variant="subtitle" className="mt-6 text-center">
A suite of paid extensions for Nx specifically designed for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A suite of paid extensions for Nx specifically designed for
A suite of paid extensions for the Nx CLI specifically designed for

nx-dev/ui-powerpack/src/lib/powerpack-features.tsx
Self-hosted cache storage
</SectionHeading>
<p className="mt-6 text-pretty text-lg">
Nx Powerpack enables you to use <Strong>AWS S3</Strong> or a{' '}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nx Powerpack enables you to use <Strong>AWS S3</Strong> or a{' '}
Nx Powerpack enables you to use <Strong>Amazon S3</Strong> or a{' '}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't probably matter a lot, but in the docs we also mention mostly "AWS S3" everywhere

nx-dev/ui-powerpack/src/lib/powerpack-features.tsx Outdated
</SectionHeading>
<p className="mt-6 text-pretty text-lg">
Nx Powerpack enables you to use <Strong>AWS S3</Strong> or a{' '}
<Strong>custom network drive</Strong> as your remote cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Strong>custom network drive</Strong> as your remote cache
<Strong>shared network drive</Strong> as your remote cache

@juristr juristr force-pushed the nxdev/powerpack-landing-page branch 3 times, most recently from 4958479 to 735112d Compare September 25, 2024 20:08
@juristr juristr marked this pull request as ready for review September 25, 2024 22:17
@juristr juristr removed the PR status: do not merge This will block a PR from being merged until this tag is removed. label Sep 25, 2024
@FrozenPandaz FrozenPandaz merged commit 529ab94 into master Sep 25, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the nxdev/powerpack-landing-page branch September 25, 2024 23:24
FrozenPandaz pushed a commit that referenced this pull request Sep 26, 2024
@juristr @FrozenPandaz
feat(nx-dev): powerpack landing page (#27963)
4a4d43e 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isaacplmann isaacplmann isaacplmann left review comments

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

Assignees

@juristr juristr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juristr @isaacplmann @FrozenPandaz