Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allow not run workflow option #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eladhaim
Copy link
Contributor

@eladhaim eladhaim commented Jan 21, 2024

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Motivation:

Closes Issues:

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@eladhaim
Copy link
Contributor Author

@meeroslav can you take a look of this?

@uribrod
Copy link

uribrod commented Feb 21, 2024

Would really nice to have it!! Great contribution!

@mandarini
Copy link
Member

Hello @eladhaim ! Thank you for your contribution! I will make sure to take a look next week and see if it makes sense for us to merge this! Thank you for your patience and understanding!

@mandarini mandarini self-assigned this Jun 11, 2024
@meeroslav
Copy link
Collaborator

meeroslav commented Sep 4, 2024

Hi @uribrod, the purpose of this orb is to guarantee no failure goes under the radar by ensuring to always run nx affected against the last successful run.

Both on-hold and not-run are not guaranteed to be successful so that would work against the fundamental requirement of this orb.

I don't think the feature proposal makes sense.

@meeroslav meeroslav added the invalid This doesn't seem right label Sep 4, 2024
@eladhaim
Copy link
Contributor Author

eladhaim commented Sep 4, 2024

so i will explain our needs, we are pushing some packages from our monorepo and updating our github repository in this process, adding tags and commits. Those commits has [skip ci] in the title to avoid cci to fire a build, but it' still get created in cci as a workflow with not_run status which get included in the calculation of the last workflow success .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants