Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deno): support esbuild #310

Merged
merged 12 commits into from
Jul 19, 2023
Merged

Conversation

charsleysa
Copy link
Contributor

@charsleysa
Copy link
Contributor Author

@jaysoo @barbados-clemens if you could look at this one at the same time as taking a look at #305 and #306 that would be much appreciated!

@nx-cloud
Copy link

nx-cloud bot commented Jun 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3678d45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple suggestions.

e2e/deno-e2e/tests/deno-integrated.spec.ts Outdated Show resolved Hide resolved
e2e/deno-e2e/tests/deno-integrated.spec.ts Outdated Show resolved Hide resolved
e2e/deno-e2e/tests/deno-integrated.spec.ts Outdated Show resolved Hide resolved
packages/deno/src/executors/esbuild/esbuild.impl.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the last change needed.
Thanks for all your hard work!

e2e/deno-e2e/tests/deno-integrated.spec.ts Outdated Show resolved Hide resolved
@barbados-clemens barbados-clemens added the scope:deno relates to the Deno plugin label Jul 19, 2023
@barbados-clemens barbados-clemens enabled auto-merge (squash) July 19, 2023 13:41
@barbados-clemens barbados-clemens merged commit a2f423b into nrwl:main Jul 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:deno relates to the Deno plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants