Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): add storybook-configuration generator #295

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jun 8, 2023

Add a generator to create a storybook configuration for remix

@Coly010 Coly010 self-assigned this Jun 8, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jun 8, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 961fcf2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@philipjfulcher
Copy link
Contributor

Code looks good, but I'd like to take some time to test.

@Coly010
Copy link
Contributor Author

Coly010 commented Jun 8, 2023

@philipjfulcher please do! There’s bound to be some kind of edge case I’ve missed. I tested it out with a component Chau directed me to in Ocean.

there is 1 caveat. There was a bug in the Nx/storybook configuration generator where it wasn’t adding the path to the viteConfig in the main.js of storybook automatically. Katerina merged a fix for that yesterday, but until a new patch is released, you’ll need to set that manually.

@Coly010 Coly010 force-pushed the remix/storybook-configuration branch 3 times, most recently from 5f08c32 to 935e9d0 Compare June 20, 2023 12:59
@Coly010 Coly010 force-pushed the remix/storybook-configuration branch from 935e9d0 to 961fcf2 Compare June 20, 2023 14:07
@Coly010 Coly010 merged commit 3dafc60 into nrwl:main Jun 23, 2023
6 checks passed
@Coly010 Coly010 deleted the remix/storybook-configuration branch June 23, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants